gh-133342: Remove sym_is_const and sym_has_type#133884
Open
tomasr8 wants to merge 2 commits intopython:mainfrom
Open
gh-133342: Remove sym_is_const and sym_has_type#133884tomasr8 wants to merge 2 commits intopython:mainfrom
sym_is_const and sym_has_type#133884tomasr8 wants to merge 2 commits intopython:mainfrom
Conversation
Member
|
LGTM. But let's wait for #132733 to merge, then your diff can be smaller as half of the manual constants will be gone :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
into
sym_is_constandsym_has_type. They can be replaced bysym_get_constandsym_get_typerespectively. This part is more of an exploration, these functions might still be useful in some situations. If we do decide to keep them, we can still simplify them quite a bit.Check out the issue for more context!
_Py_uop_sym_is_const#133342